Bug 269843

Summary:	net-misc/italc-1.0.9 fails with --as-needed
Product:	Gentoo Linux	Reporter:	Christian Faulhammer (RETIRED) <fauli>
Component:	New packages	Assignee:	Markus Ullmann (RETIRED) <jokey>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	haavardw, spatz, xarthisius
Priority:	High	Keywords:	Inclusion
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	129413
Attachments:	build.log italc-1.0.9-gcc4-4.patch Fix compilation with --as-needed and respect LDFLAGS adding patch fixing as-needed issues

Description Christian Faulhammer (RETIRED) gentoo-dev

2009-05-14 13:21:37 UTC

Both stable and testing versions fail with Qt 4.5, please fix to get Qt 4.5 into stable.

Comment 1 Christian Faulhammer (RETIRED) gentoo-dev

2009-05-14 13:21:55 UTC

Created attachment 191260 [details]
build.log

Comment 2 Markus Ullmann (RETIRED) gentoo-dev

2009-05-16 08:14:35 UTC

Stabling 1.0.9 is a good idea anyway so let's go there

Comment 3 Markus Ullmann (RETIRED) gentoo-dev

2009-05-16 08:14:52 UTC

Please test and mark stable

Comment 4 Thomas Anderson (tanderson) (RETIRED) gentoo-dev

2009-05-18 20:52:59 UTC

amd64 stable

Comment 5 Markus Meier gentoo-dev

2009-05-24 09:10:49 UTC

x86 stable, all arches done.

Comment 6 Christian Faulhammer (RETIRED) gentoo-dev

2009-05-25 17:00:29 UTC

Still fails with Qt 4.5

Comment 7 Håvard Wall 2009-05-29 15:42:21 UTC

Created attachment 192896 [details, diff]
italc-1.0.9-gcc4-4.patch

Compile fix for gcc-4.4
Patch grabbed from upstream svn (last part of change r435).

Comment 8 Dror Levin (RETIRED) gentoo-dev

2009-06-01 12:51:04 UTC

Created attachment 193141 [details, diff]
Fix compilation with --as-needed and respect LDFLAGS

The problem with italc-1.0.9 seems to be --as-needed and not qt-4.5 — it failed for me with --as-needed and worked without it and I have qt-4.5.
This patch, partly adapted from the one for 1.0.3 in the tree, fixes the compilation failure and removes a QA warning regarding LDFLAGS being ignored.
The package now compiles with qt-4.5 with or without --as-needed.

Comment 9 Christian Faulhammer (RETIRED) gentoo-dev

2009-06-02 17:16:49 UTC

I thought, I had --as-needed disabled in my chroot...but now as you say it, it looks as a failure there.  Sorry for all the noise.

Comment 10 Diego Elio Pettenò (RETIRED) gentoo-dev

2009-09-28 16:59:31 UTC

Comment on attachment 193141 [details, diff]
Fix compilation with --as-needed and respect LDFLAGS

Err no, LDFLAGS should not be put _at the end_, please review the asneeded fixing guide for the correct ordering of parameters.

Comment 11 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2009-10-16 13:31:00 UTC

Created attachment 207311 [details, diff]
adding patch

Comment 12 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2009-10-16 13:31:27 UTC

Created attachment 207313 [details, diff]
fixing as-needed issues

Comment 13 Christian Faulhammer (RETIRED) gentoo-dev

2009-11-10 01:13:20 UTC

Thank you Kacper for the work and patience.  Fixed in CVS.