Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 521434

Summary: dev-libs/syck-0.55-r4: suspicious use of einstall
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED FIXED    
Severity: QA    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard: suspicious-einstall
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 521420    
Attachments: syck-0.55-r4.ebuild.patch

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-08-28 20:37:28 UTC
Please check whether the use of 'einstall' in this ebuild is actually
needed. From a quick glance at the Makefile, it seems to have proper
support for DESTDIR.

Therefore, if possible please replace the call to 'einstall' with proper
'default' or 'emake DESTDIR="${D}" install'. Thanks.
Comment 1 Patrice Clement (RETIRED) gentoo-dev 2014-11-29 22:39:29 UTC
Created attachment 390614 [details, diff]
syck-0.55-r4.ebuild.patch

Hi Michal

Thanks for pointing this out. Indeed, it does work with emake. I've attached a patch with your suggestion. I'm going to revbump the ebuild for the time being.
Comment 2 Pacho Ramos gentoo-dev 2014-12-19 09:26:09 UTC
fixed in -r5

*syck-0.55-r5 (29 Nov 2014)

  29 Nov 2014; Patrice Clement <monsieurp@gentoo.org> +syck-0.55-r5.ebuild,
  syck-0.55-r4.ebuild:
  Replace einstall with emake install and revbump the ebuild. See #521434.