Bug 630634

Summary:	dev-lang/crystal-0.23.1 doesn't merge with LLVM 5.x
Product:	Gentoo Linux	Reporter:	Renich Bon Ciric <renich>
Component:	Current packages	Assignee:	Lixiao Chen <longlene>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jstein, proxy-maint, slyfox
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	408963
Attachments:	Build log LLVM patch

Description Renich Bon Ciric 2017-09-11 07:01:06 UTC

Created attachment 493816 [details]
Build log

Fixed here: https://github.com/crystal-lang/crystal/pull/4821

Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev

2017-09-15 21:01:58 UTC

I got a bit lost in the list of merges and did not try hard to check which
patches should be backported. Options are:
- someone can attach needed patches to this bugzilla (or send a pull request!)
- we wait for next upstream release and pick it up

Comment 2 Renich Bon Ciric 2017-09-15 23:59:20 UTC

Created attachment 494726 [details, diff]
LLVM patch

This one works.

Comment 3 Larry the Git Cow gentoo-dev

2017-09-16 10:54:53 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a5770fdf734d8d6d4bf95f6778adf0d024efb705

commit a5770fdf734d8d6d4bf95f6778adf0d024efb705
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2017-09-16 10:54:30 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2017-09-16 10:54:30 +0000

    dev-lang/crystal: add llvm-5 support, bug #630634
    
    Thanks to Renich Bon Ciric who found the problem
    and found out the patch!
    
    Reported-by: Renich Bon Ciric
    Closes: https://bugs.gentoo.org/630634
    Package-Manager: Portage-2.3.8, Repoman-2.3.3

 dev-lang/crystal/crystal-0.23.1.ebuild             |   1 +
 dev-lang/crystal/files/crystal-0.23.1-llvm-5.patch | 837 +++++++++++++++++++++
 2 files changed, 838 insertions(+)

Comment 4 Renich Bon Ciric 2017-09-16 16:46:12 UTC

Thanks, guys! Next release promises to overcome this hurdle.