Bug 725988 – sys-fs/atari-fdisk fails to compile

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2020-05-29 06:51:23 UTC]

This is an auto-filed bug because sys-fs/atari-fdisk fails to compile.
The issue was originally discovered on amd64, but it may be reproducible on other arches as well.
If you think that a different summary clarifies the issue better, feel free to change it.
Attached build log and emerge --info.

NOTE:
If you need further logs, feel free to ask.

[Comment 1 Agostino Sarubbo 2020-05-29 06:51:29 UTC]

Created attachment 642416 [details]
build.log

build log and emerge --info

[Comment 2 Vladislav Dudar 2021-03-23 08:32:46 UTC]

I just slapped a copy on my amd64 box and it compiles fine. Probably because I'm too lazy to update my OS and using GCC 9, but I may be able to help.

I've dealt with a lot of old software, and there's this one annoying thing that GCC 10 changed the default compiler options from -fcommon to -fno-common, causing multiple definition problems on countless occasions.

Try forcing the compiler to use -fcommon by adding it to CFLAGS and please reply back.

[Comment 3 Vladislav Dudar 2021-08-20 19:57:50 UTC]

Created attachment 734644 [details, diff]
Fix for atari-fdisk compile

[Comment 4 Vladislav Dudar 2021-08-20 19:58:30 UTC]

Got this thingy fixed, didn't test because I don't have an Atari but it runs.

[Comment 5 Agostino Sarubbo 2021-08-21 04:48:58 UTC]

Hello, thanks for the patch. I believe you can speed up the process by making a pull-request via Github.

[Comment 6 Larry the Git Cow 2021-09-04 22:36:14 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a960513f2164073d5d895162ff02fd28bca73c18

commit a960513f2164073d5d895162ff02fd28bca73c18
Author:     James Le Cuirot <[e-mail]>
AuthorDate: 2021-09-04 21:57:29 +0000
Commit:     James Le Cuirot <[e-mail]>
CommitDate: 2021-09-04 22:35:49 +0000

    sys-fs/atari-fdisk: Patch to fix common global issue
    
    Closes: https://bugs.gentoo.org/725988
    Package-Manager: Portage-3.0.22, Repoman-3.0.3
    Signed-off-by: James Le Cuirot <[e-mail]>

 sys-fs/atari-fdisk/atari-fdisk-0.7.1.5.4-r1.ebuild | 48 ++++++++++++++++++++++
 .../files/atari-fdisk-0.7.1.5.4-globals.patch      | 30 ++++++++++++++
 2 files changed, 78 insertions(+)

[Comment 7 James Le Cuirot 2021-09-04 22:36:30 UTC]

Thanks but I cooked up a better patch.