Created attachment 928408 [details, diff] corrected -fno-common patch While the current patch ( purple-libnotify-plus-2.99.1-fno-common.patch ) allows the plugin to build it will not load. (04:00:09) plugins: probing /usr/lib64/purple-2/purple-libnotify+.so (04:00:09) plugins: /usr/lib64/purple-2/purple-libnotify+.so is not loadable: undefined symbol: notify_plus_data (04:00:09) plugins: probing /usr/lib64/purple-2/buddynote.so doing a simple replacement of struct { .. }; with extern struct { .. }; is insufficient. The attached revised patch allows the plugin to build and load. (04:23:04) plugins: probing /usr/lib64/purple-2/purple-libnotify+.so (04:23:04) plugins: probing /usr/lib64/purple-2/statenotify.so I note that upstream has resolved this in the next release (2.99.2 -now using meson build) by adding -fcommon to the cflags https://github.com/sardemff7/purple-libnotify-plus/blob/2939dd5a06e1c4df7a9979b0b8c3ab42490819f6/meson.build#L26
commit 8a296ea717812962ffe8a8aef243e3e8c34646d6 Author: Jakov Smolic <jakov.smolic@sartura.hr> Date: Wed Nov 25 18:37:23 2020 +0100 x11-plugins/purple-libnotify-plus: port to EAPI 7 Closes: https://bugs.gentoo.org/717422 Package-Manager: Portage-3.0.8, Repoman-3.0.1 Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr> Signed-off-by: David Seifert <soap@gentoo.org>
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b28ab1cec66081d2f177f4d9e7990a524a22005a commit b28ab1cec66081d2f177f4d9e7990a524a22005a Author: Jakov Smolić <jsmolic@gentoo.org> AuthorDate: 2025-05-11 19:04:44 +0000 Commit: Jakov Smolić <jsmolic@gentoo.org> CommitDate: 2025-05-11 19:12:14 +0000 x11-plugins/purple-libnotify-plus: Update gcc-11 patch The old patch did not fix the code correctly, so update it to enable the plugin to work. Thanks to Bill Prendergast for providing the patch. Fixes: 8a296ea717812962ffe8a8aef243e3e8c34646d6 Closes: https://bugs.gentoo.org/955791 Bug: https://bugs.gentoo.org/717422 Signed-off-by: Jakov Smolić <jsmolic@gentoo.org> .../purple-libnotify-plus-2.99.1-fno-common.patch | 26 ++++++++++++++++++++-- ...uild => purple-libnotify-plus-2.99.1-r1.ebuild} | 2 +- 2 files changed, 25 insertions(+), 3 deletions(-)
